Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handling IllegalArgumentException caused by Discovery Disabled #7937
handling IllegalArgumentException caused by Discovery Disabled #7937
Changes from 1 commit
16fb4b7
864831a
c45da9b
3e1bbaa
ce0cd8f
e9b91d4
d7b5231
526c518
8fa1856
55ebf8e
7a67256
7886792
3a3e5ac
c8d353e
75a53c0
7fcf8fd
c92d36c
7f2c5e4
0f4f4dc
ac7beb3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the discovery port is empty, the default port will be used, right? Can we add a test for the expected outcome?
And in that case, should this log be moved to debug? "Using default port for enode"