Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round change upon f+1 RC messages (experimental option) #7838

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Round change upon f+1 RC messages (experimental option) #7838

wants to merge 12 commits into from

Conversation

pullurib
Copy link
Contributor

@pullurib pullurib commented Oct 31, 2024 •
edited
Loading

PR description

  • Added an experimental option to enable round change upon receiving f+1 valid round change messages from different validators for future rounds
  • move to least of the future rounds
  • If node is proposer for the new round, wait till the new round receives ceil(2*N/3) quorum of RC messages to propose the new block.

Plan going ahead

Next release

--Xqbft-enable-early-round-change = false

- No f+1 behaviour

--Xqbft-enable-early-round-change = true

- f+1 behaviour

Besu 25.6.0

Remove --Xqbft-enable-early-round-change (NOT make it --qbft-enable-early-round-change)

Fixed Issue(s)

#1822

matthew1001
matthew1001 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@matthew1001 matthew1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some small comments

consensus/common/src/main/java/org/hyperledger/besu/consensus/common/bft/BftHelpers.java Outdated Show resolved Hide resolved
...sts/tests/src/test/java/org/hyperledger/besu/tests/acceptance/bftsoak/BftMiningSoakTest.java Outdated Show resolved Hide resolved
besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java Outdated Show resolved Hide resolved
@jframe
Copy link
Contributor

jframe commented Dec 3, 2024

I forgot about this, just having a look now. Hopefully won't take me log to get through it.

Bhanu Pulluri added 3 commits December 3, 2024 15:43
@macfarla
Copy link
Contributor

@pullurib compile errors

@macfarla macfarla marked this pull request as draft December 17, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew1001 matthew1001 matthew1001 approved these changes

@jframe jframe jframe approved these changes

Assignees

@jframe jframe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pullurib @jframe @macfarla @matthew1001