feat: Refactor Node DNS Resolver to use vertx virtual threads #7189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Usman Saleem <[email protected]>
fab-10
approved these changes
Jun 7, 2024
Comment on lines
152
to
157
| // TODO: this always return true because the visitor is reference to list.add | ||
| return visitor.visit(node.nodeRecord()); | ||
| } | ||
| case DNSEntry.ENRTree tree -> { | ||
| for (String e : tree.entries()) { | ||
| // TODO: When would this ever return false? |
There was a problem hiding this comment.
could you do something about these TODO?
There was a problem hiding this comment.
These were leftover questions for myself after I "adapted" code from Tuweni, I'll remove these comments :).
Signed-off-by: Usman Saleem <[email protected]>
Signed-off-by: Usman Saleem <[email protected]>
gtebrean
pushed a commit
to gtebrean/besu
that referenced
this pull request
Jun 26, 2024
…edger#7189) Signed-off-by: Usman Saleem <[email protected]> Signed-off-by: George Tebrean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Refactor Node DNS Resolver to use vertx virtual threads (Java 21).
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests