[#6201] Duplicate "Terminating connection" message on peer connections #6284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Lutzardo <[email protected]>
|
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 18, 2023
Signed-off-by: David Lutzardo <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: jflo <[email protected]>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 18, 2023
Signed-off-by: David Lutzardo <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 18, 2023
Signed-off-by: David Lutzardo <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: jflo <[email protected]>
jflo
added a commit
that referenced
this pull request
Dec 19, 2023
* Increase scope of reference tests (#6287) Add new forks to transaction tests, add bad rlp to rlp ref tests. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: jflo <[email protected]> * Add trace to web socket JSON/RPC responses (#6285) * Add trace to web socket JSON/RPC responses Signed-off-by: Matthew Whitehead <[email protected]> * Don't throw runtime exception if we can't parse JSON for trace Signed-off-by: Matthew Whitehead <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: jflo <[email protected]> * [MINOR] Include Enode URL in error message if parsing exception (#6288) * include the actual Enode URL in the error message if IP can't be resolved --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: jflo <[email protected]> * Execute the terminatedImmediately method only once (#6284) Signed-off-by: David Lutzardo <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: jflo <[email protected]> * move forest class to a specific package (#6293) cleaning up the worldstate section, moving and renaming everything that is forest into a specific package in order to clarify the difference between Bonsai and Forest in the code. --------- Signed-off-by: Karim Taam <[email protected]> Signed-off-by: matkt <[email protected]> Signed-off-by: jflo <[email protected]> * removed vintage junit dependency (#6296) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: jflo <[email protected]> * updated cli and chainimport/export tests to junit 5 (#6281) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: jflo <[email protected]> * [MINOR] CLI Subcommands migrate to junit 5 (#6282) * updated cli and chainimport/export tests to junit 5 Signed-off-by: Sally MacFarlane <[email protected]> * subcommands and besucommand test to junit5 Signed-off-by: Sally MacFarlane <[email protected]> * removed duplicate line Signed-off-by: Sally MacFarlane <[email protected]> * removed vintage junit dep Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Signed-off-by: jflo <[email protected]> * [MINOR] add genesis file name to config overview (#6297) * add genesis file name to config overview Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: jflo <[email protected]> * create trie package for bonsai and forest (#6300) Signed-off-by: Karim Taam <[email protected]> Signed-off-by: matkt <[email protected]> Signed-off-by: jflo <[email protected]> * [MINOR] More cli tests to junit 5 (#6283) * more CLI and services tests to junit5 --------- Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Signed-off-by: jflo <[email protected]> * Update Gradle plugins and replace unmaintained license plugin (#6275) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: jflo <[email protected]> * Quick fix to avoid a tight loop when processing added blocks in txpool (#6309) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: jflo <[email protected]> * uprev to version 23.10.3-RC4 Signed-off-by: jflo <[email protected]> * mark deleted slot during clear storage step Signed-off-by: Karim Taam <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: jflo <[email protected]> Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: David Lutzardo <[email protected]> Signed-off-by: Karim Taam <[email protected]> Signed-off-by: matkt <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Matt Whitehead <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: David Lutzardo <[email protected]> Co-authored-by: Karim TAAM <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
There are two invocations to the method "terminateConnection" (ApiHandler and NettyPeerConnection). In the case of NettyPeerConnection it is called inside a listener.
The correct thing is to control that the terminateConnection method is executed once even if it is called several times.
Fixed Issue(s)
#6201