WIP QBFT Empty Block Period #4634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Dudley <[email protected]>
Delay start of round by cancelling roundChangeTimer and adding short delay to a new BlockTimer to create a loop In that loop (In QbftBlockHeightManager), check if emptyBlockPeriod has been surpassed. Hardcoded values and buggy delay timing to fix. Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Move isProposer check after block building and sendProposalMessage if true Signed-off-by: Simon Dudley <[email protected]>
Closed
Do nothing when emptyBlockPeriod has expired instead of restarting the BlockTimer Signed-off-by: Simon Dudley <[email protected]>
|
Closing, pending new work on #3810. @siladu @matthew1001 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
#3810
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog