Handle rocksdb error during size estimate

Signed-off-by: Simon Dudley <[email protected]>
hyperledger · Jan 31, 2024 · fee97ba · fee97ba
1 parent ec36a1e
commit fee97ba
Showing 1 changed file with 17 additions and 12 deletions.
diff --git a/besu/src/main/java/org/hyperledger/besu/cli/subcommands/storage/TrieLogSubCommand.java b/besu/src/main/java/org/hyperledger/besu/cli/subcommands/storage/TrieLogSubCommand.java
@@ -174,19 +174,24 @@ private long estimatedSizeOfTrieLogs() {
               .concat(DATABASE_PATH);
 
       AtomicLong estimatedSaving = new AtomicLong(0L);
-      RocksDbHelper.forEachColumnFamily(
-          dbPath,
-          (rocksdb, cfHandle) -> {
-            try {
-              if (Arrays.equals(cfHandle.getName(), TRIE_LOG_STORAGE.getId())) {
-                estimatedSaving.set(
-                    Long.parseLong(
-                        rocksdb.getProperty(cfHandle, "rocksdb.estimate-live-data-size")));
+      try {
+        RocksDbHelper.forEachColumnFamily(
+            dbPath,
+            (rocksdb, cfHandle) -> {
+              try {
+                if (Arrays.equals(cfHandle.getName(), TRIE_LOG_STORAGE.getId())) {
+                  estimatedSaving.set(
+                      Long.parseLong(
+                          rocksdb.getProperty(cfHandle, "rocksdb.estimate-live-data-size")));
+                }
+              } catch (RocksDBException e) {
+                throw new RuntimeException(e);
               }
-            } catch (RocksDBException e) {
-              throw new RuntimeException(e);
-            }
-          });
+            });
+      } catch (Exception e) {
+        LOG.warn("Error while estimating trie log size, returning 0 for estimate", e);
+        return 0L;
+      }
 
       return estimatedSaving.get();
     }