7582: Loosen restriction to allow fewer or equal results than request…

…ed, but not more Signed-off-by: Matilda Clerke <[email protected]>
hyperledger · Jan 9, 2025 · 8b18e4b · 8b18e4b
1 parent 9272872
commit 8b18e4b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/...yperledger/besu/ethereum/eth/manager/peertask/task/GetPooledTransactionsFromPeerTask.java b/...yperledger/besu/ethereum/eth/manager/peertask/task/GetPooledTransactionsFromPeerTask.java
@@ -53,7 +53,7 @@ public List<Transaction> processResponse(final MessageData messageData)
     final PooledTransactionsMessage pooledTransactionsMessage =
         PooledTransactionsMessage.readFrom(messageData);
     final List<Transaction> responseTransactions = pooledTransactionsMessage.transactions();
-    if (responseTransactions.size() != hashes.size()) {
+    if (responseTransactions.size() > hashes.size()) {
       throw new InvalidPeerTaskResponseException(
           "Response transaction count does not match request hash count");
     }

diff --git a/...ledger/besu/ethereum/eth/manager/peertask/task/GetPooledTransactionsFromPeerTaskTest.java b/...ledger/besu/ethereum/eth/manager/peertask/task/GetPooledTransactionsFromPeerTaskTest.java
@@ -59,12 +59,11 @@ public void testProcessResponse() throws InvalidPeerTaskResponseException {
 
   @Test
   public void testProcessResponseWithIncorrectTransactionCount() {
-    List<Hash> hashes = List.of(Hash.EMPTY, Hash.EMPTY_LIST_HASH);
+    List<Hash> hashes = List.of(Hash.EMPTY);
     GetPooledTransactionsFromPeerTask task = new GetPooledTransactionsFromPeerTask(hashes);
 
-    Transaction transaction = GENERATOR.transaction();
     PooledTransactionsMessage pooledTransactionsMessage =
-        PooledTransactionsMessage.create(List.of(transaction));
+        PooledTransactionsMessage.create(List.of(GENERATOR.transaction(), GENERATOR.transaction()));
 
     InvalidPeerTaskResponseException exception =
         Assertions.assertThrows(