Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document override functionality for eth_call and eth_estimateGas #1756

Merged
merged 7 commits into from
Jan 13, 2025

Conversation

Signed-off-by: bgravenorst <[email protected]>
@bgravenorst bgravenorst requested a review from a team as a code owner January 8, 2025 04:17
Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 11:33pm

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - suggestion on wording for state changes to be temporary, for the purposes of the transaction simulation. Not a strong opinion

docs/public-networks/reference/api/objects.md Outdated Show resolved Hide resolved
docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions, LGTM.

docs/public-networks/how-to/send-transactions.md Outdated Show resolved Hide resolved
docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
Co-authored-by: Alexandra Carrillo <[email protected]>
Signed-off-by: Byron Gravenorst <[email protected]>
@bgravenorst bgravenorst merged commit de72fff into hyperledger:main Jan 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional eth_call parameter.
3 participants