Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xperimental features and add table for how sync works #1662

Merged
merged 14 commits into from
Oct 4, 2024
Merged

Add xperimental features and add table for how sync works #1662

merged 14 commits into from
Oct 4, 2024

Conversation

joaniefromtheblock
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock commented Jul 25, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Jul 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 2:29am

@joaniefromtheblock joaniefromtheblock marked this pull request as ready for review August 12, 2024 21:38
@joaniefromtheblock joaniefromtheblock requested a review from a team as a code owner August 12, 2024 21:38
@joaniefromtheblock
Copy link
Contributor Author

@matthew1001 Please review when you have a chance.

matthew1001
matthew1001 reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@matthew1001 matthew1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes look OK, but I've left a more general comment about whether this single topic is becoming unwieldy in trying to describe public and private network differences in one place.

@joaniefromtheblock
Copy link
Contributor Author

@matthew1001 please take another look. Does this PR look like it is good to go now?

joaniefromtheblock and others added 5 commits September 30, 2024 19:40
@joaniefromtheblock
fix typo
179956d 
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock
fix typo
3f7d669 
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock
add suggestions
db5836b 
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock @siladu
Apply suggestions from code review
9ca836e 
Co-authored-by: Simon Dudley <[email protected]>
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock
fix broken links
26636b6 
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock @alexandratran
Apply suggestions from code review
a35faf2 
Co-authored-by: Alexandra Carrillo <[email protected]>
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock joaniefromtheblock force-pushed the xperimental-method-update branch from 0ee83b3 to 606c2a4 Compare October 4, 2024 00:39
@joaniefromtheblock
update broken
7186885 
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock joaniefromtheblock force-pushed the xperimental-method-update branch from 0dcf52e to 7186885 Compare October 4, 2024 00:58
alexandratran
alexandratran reviewed Oct 4, 2024
View reviewed changes
docs/public-networks/concepts/node-sync.md Outdated Show resolved Hide resolved
docs/public-networks/concepts/node-sync.md Outdated Show resolved Hide resolved
docs/public-networks/concepts/node-sync.md Outdated Show resolved Hide resolved
docs/public-networks/concepts/node-sync.md Outdated Show resolved Hide resolved
docs/private-networks/concepts/node-sync-private.md Outdated Show resolved Hide resolved
docs/private-networks/concepts/node-sync-private.md Outdated Show resolved Hide resolved
docs/private-networks/concepts/node-sync-private.md Outdated Show resolved Hide resolved
@joaniefromtheblock @alexandratran
Apply suggestions from code review
9d62ee0 
Co-authored-by: Alexandra Carrillo <[email protected]>
Signed-off-by: Joan E <[email protected]>
alexandratran
alexandratran approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once final notes are addressed.

docs/private-networks/how-to/configure/consensus/ibft.md Outdated Show resolved Hide resolved
docs/private-networks/how-to/configure/consensus/index.md Outdated Show resolved Hide resolved
docs/private-networks/how-to/configure/consensus/qbft.md Outdated Show resolved Hide resolved
@joaniefromtheblock @alexandratran
Apply suggestions from code review
cf83455 
Co-authored-by: Alexandra Carrillo <[email protected]>
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock joaniefromtheblock merged commit 575a049 into main Oct 4, 2024
10 checks passed
@joaniefromtheblock joaniefromtheblock deleted the xperimental-method-update branch October 4, 2024 05:17
@alexandratran alexandratran mentioned this pull request Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgravenorst bgravenorst bgravenorst left review comments

@siladu siladu siladu left review comments

@alexandratran alexandratran alexandratran approved these changes

@matthew1001 matthew1001 matthew1001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WIP: Add experimental --Xsnapsync-bft-enabled option
5 participants
@joaniefromtheblock @siladu @matthew1001 @alexandratran @bgravenorst