Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes 1615:temp redirect to perm #1635

Merged
merged 1 commit into from
Jun 26, 2024
Merged

fixes 1615:temp redirect to perm #1635

merged 1 commit into from
Jun 26, 2024

Conversation

m4sterbunny
Copy link
Contributor

@m4sterbunny m4sterbunny commented Jun 26, 2024

Description

fixes #1615

Issue(s) fixed

: #1615
reissued PR (with sign!)

@m4sterbunny m4sterbunny requested a review from a team as a code owner June 26, 2024 07:26
Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 7:34am

Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the github keyword phrase for linking issues is "fixes #1615" including the number sign. (See examples: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)

@m4sterbunny m4sterbunny merged commit 8ee6927 into hyperledger:main Jun 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect cleanup post 1606 issue PR 1610
2 participants