Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Did type in message crate #1171

Closed
wants to merge 3 commits into from

Conversation

GHkrishna
Copy link

Resolves #1165

Use did_parser_nom's Did type in message crates instead of string so as to parse & verify DIDs upon message deserialization

@Patrik-Stas
Copy link
Contributor

Hi @GHkrishna thank you for contribution!

Sorry for delayed feedback, I've just enabled the CI run - as you can see the project doesn't compile now, you will need to sync up the rest of the codebase with these changes (won't be huge amount of work, but might be scattered across the board).

Additionally you need to make sure your commits are signed off - see the failing DCO check https://github.com/hyperledger/aries-vcx/pull/1171/checks?check_run_id=23276330183

@Patrik-Stas
Copy link
Contributor

Closing due inactivity, feel free to reopen and continue later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Did type in messages crate
2 participants