Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reorganize project #4850

Closed

Conversation

nxsaken
Copy link
Contributor

@nxsaken nxsaken commented Jul 16, 2024

Description

This fixes the error with cargo install:

package `.../client/tests/integration/smartcontracts/executor_custom_data_model/Cargo.toml` is a member of the wrong workspace
  • move all binary crates to /bins
  • move all library crates to /libs
  • move executors, smart contracts and triggers to /samples
  • unnest iroha_executor and iroha_trigger from iroha_smart_contract
  • rename crate directories to match their actual names (except nested utility crates)

Benefits

  • binaries can be installed with cargo install
  • separation between binaries and libraries
  • more predictable structure and names

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@nxsaken nxsaken marked this pull request as ready for review July 16, 2024 13:25
@nxsaken nxsaken self-assigned this Jul 16, 2024
@nxsaken nxsaken force-pushed the fix/reorganize-project branch from f933143 to a2691b5 Compare July 17, 2024 07:36
@mversic
Copy link
Contributor

mversic commented Jul 17, 2024

I think you should break this into several PRs

@nxsaken nxsaken force-pushed the fix/reorganize-project branch 2 times, most recently from 3ef8ca9 to 596ad4e Compare July 18, 2024 06:33
@nxsaken nxsaken changed the title refactor: reorganize project, fix Cargo issue refactor: reorganize project Jul 18, 2024
Signed-off-by: Nurzhan Sakén <[email protected]>
@nxsaken nxsaken force-pushed the fix/reorganize-project branch from 596ad4e to 34b7a05 Compare July 18, 2024 06:39
@Erigara
Copy link
Contributor

Erigara commented Jul 18, 2024

can this error be fixed in less invasive way?

@nxsaken
Copy link
Contributor Author

nxsaken commented Jul 18, 2024

Superseded by #4863.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants