-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #4390: include trigger id in trigger entrypoint #4391
Merged
mversic
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
mversic:trigger_id_in_entrypoint
Mar 28, 2024
Merged
[feature] #4390: include trigger id in trigger entrypoint #4391
mversic
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
mversic:trigger_id_in_entrypoint
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
requested review from
s8sato,
Arjentix,
SamHSmith,
outoftardis,
Erigara,
0x009922,
DCNick3,
VAmuzing and
Asem-Abdelhady
as code owners
March 27, 2024 13:37
github-actions
bot
added
Enhancement
New feature or request
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
labels
Mar 27, 2024
mversic
force-pushed
the
trigger_id_in_entrypoint
branch
3 times, most recently
from
March 27, 2024 14:07
8dc4445
to
a469e7a
Compare
mversic
force-pushed
the
trigger_id_in_entrypoint
branch
2 times, most recently
from
March 27, 2024 17:45
b60e41b
to
36e5396
Compare
mversic
force-pushed
the
trigger_id_in_entrypoint
branch
from
March 28, 2024 07:53
36e5396
to
e0de0b8
Compare
DCNick3
reviewed
Mar 28, 2024
client/tests/integration/smartcontracts/query_assets_and_save_cursor/src/lib.rs
Show resolved
Hide resolved
DCNick3
previously approved these changes
Mar 28, 2024
mversic
force-pushed
the
trigger_id_in_entrypoint
branch
from
March 28, 2024 08:19
e0de0b8
to
5593269
Compare
…point Signed-off-by: Marin Veršić <[email protected]>
mversic
force-pushed
the
trigger_id_in_entrypoint
branch
from
March 28, 2024 08:31
5593269
to
cb242cf
Compare
Erigara
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please notify SDKs that permission token name was changed.
DCNick3
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api-changes
Changes in the API for client libraries
Enhancement
New feature or request
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SetKeyValue
/RemoveKeyValue
for triggerLinked issue
Closes #{issue_number}
Benefits
Checklist
CONTRIBUTING.md