Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #4390: include trigger id in trigger entrypoint #4391

Merged

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Mar 27, 2024

Description

  • Added SetKeyValue/RemoveKeyValue for trigger
  • added corresponding metadata changed events for trigger
  • added trigger id to trigger entrypoint arguments
  • verified with a simple test

Linked issue

Closes #{issue_number}

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Mar 27, 2024
@mversic mversic force-pushed the trigger_id_in_entrypoint branch 3 times, most recently from 8dc4445 to a469e7a Compare March 27, 2024 14:07
@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Mar 27, 2024
@mversic mversic force-pushed the trigger_id_in_entrypoint branch 2 times, most recently from b60e41b to 36e5396 Compare March 27, 2024 17:45
@coveralls
Copy link

coveralls commented Mar 27, 2024

Pull Request Test Coverage Report for Build 8464521475

Details

  • 13 of 150 (8.67%) changed or added relevant lines in 18 files are covered.
  • 5250 unchanged lines in 95 files lost coverage.
  • Overall coverage increased (+0.8%) to 57.595%

Changes Missing Coverage Covered Lines Changed/Added Lines %
smart_contract/trigger/derive/src/entrypoint.rs 0 1 0.0%
core/src/smartcontracts/isi/mod.rs 0 2 0.0%
core/src/smartcontracts/wasm.rs 0 2 0.0%
data_model/src/visit.rs 0 2 0.0%
smart_contract/executor/derive/src/default.rs 0 2 0.0%
core/src/smartcontracts/isi/triggers/specialized.rs 0 3 0.0%
smart_contract/executor/src/permission.rs 0 3 0.0%
smart_contract/src/lib.rs 0 3 0.0%
data_model/src/events/data/events.rs 0 4 0.0%
tools/kagami/src/genesis.rs 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
primitives/src/conststr.rs 1 91.14%
crypto/src/hash.rs 1 73.78%
ffi/derive/src/convert.rs 1 84.45%
primitives/src/lib.rs 1 0.0%
core/src/sumeragi/network_topology.rs 1 98.78%
primitives/src/must_use.rs 2 74.29%
crypto/src/signature/bls/mod.rs 2 0.0%
config/src/snapshot.rs 3 78.57%
data_model/derive/src/has_origin.rs 3 95.16%
config/src/kura.rs 3 80.0%
Totals Coverage Status
Change from base Build 7884695009: 0.8%
Covered Lines: 23359
Relevant Lines: 40557

💛 - Coveralls

@DCNick3 DCNick3 self-assigned this Mar 28, 2024
@mversic mversic force-pushed the trigger_id_in_entrypoint branch from 36e5396 to e0de0b8 Compare March 28, 2024 07:53
DCNick3
DCNick3 previously approved these changes Mar 28, 2024
@mversic mversic force-pushed the trigger_id_in_entrypoint branch from 5593269 to cb242cf Compare March 28, 2024 08:31
@mversic mversic requested a review from DCNick3 March 28, 2024 08:31
Copy link
Contributor

@Erigara Erigara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please notify SDKs that permission token name was changed.

@mversic mversic merged commit b2b8d40 into hyperledger-iroha:iroha2-dev Mar 28, 2024
15 checks passed
@mversic mversic deleted the trigger_id_in_entrypoint branch March 28, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-changes Changes in the API for client libraries Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants