Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci]: Unsync auto-labels. Fix config-changes condition #4316

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

s8sato
Copy link
Contributor

@s8sato s8sato commented Feb 22, 2024

Description

Linked issue

  1. The bot was observed to remove a label manually added to PR: [feature] #4212: Prevent account registration without signatures #4309 (comment)
  2. At the same time, the bot was observed to notify false-positive config-changes due to its wrong definition

Benefits

  1. Always prioritize manual labeling/unlabeling
  2. Necessary and sufficient config-changes notifications

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added CI iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Feb 22, 2024
@s8sato s8sato force-pushed the ci/fix/unsync_labels branch from b13753b to c5ecbdb Compare February 26, 2024 12:08
@s8sato s8sato changed the title [ci]: Unsync auto-labels and actual changes [ci]: Unsync auto-labels. Fix config-changes condition Feb 26, 2024
@s8sato s8sato force-pushed the ci/fix/unsync_labels branch from b6d092e to 8c4b2e0 Compare February 26, 2024 12:22
@s8sato s8sato merged commit 4de547f into hyperledger-iroha:iroha2-dev Feb 26, 2024
3 checks passed
@s8sato s8sato deleted the ci/fix/unsync_labels branch February 26, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants