Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[discussion] Rename configs/swarm? #4293

Closed
0x009922 opened this issue Feb 18, 2024 · 1 comment · Fixed by #4862
Closed

[discussion] Rename configs/swarm? #4293

0x009922 opened this issue Feb 18, 2024 · 1 comment · Fixed by #4862
Assignees
@0x009922
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested

Comments

@0x009922
Copy link
Contributor

After #4239, docker-compose configs (YAML files and related Iroha configs) are placed into the configs/swarm directory. @mversic suggested that renaming it to configs/docker might be clearer. I would go further and suggest naming it configs/docker_compose, because Docker configs (i.e. Dockerfiles) are still in the repo root.
@0x009922 0x009922 added question Further information is requested iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Feb 18, 2024
This was referenced Feb 18, 2024
Merged
Closed
@BAStos525 BAStos525 mentioned this issue Feb 20, 2024
Merged
5 tasks
@0x009922 0x009922 mentioned this issue Mar 18, 2024
Closed
5 tasks
@0x009922 0x009922 self-assigned this Mar 18, 2024
@mversic
Copy link
Contributor

mversic commented Jul 9, 2024

related to #4320

This was referenced Jul 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x009922 0x009922

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: rename configs to defaults, remove swarm nxsaken/iroha
2 participants
@0x009922 @mversic