Skip to content

Commit

Permalink
Merge pull request #496 from hyperledger/ryjones-patch-1
Browse files Browse the repository at this point in the history
Remove rocket chat
  • Loading branch information
yeasy authored Nov 17, 2022
2 parents 828c588 + 53e6041 commit fdd24f6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ In brief, if you want to contribute, create or find some `To Do` item, and assig

## 3. Questions and discussions

* [Chat](https://chat.hyperledger.org/channel/cello): technical discussions and questions, login with your LFID.
* [Chat](https://discord.gg/hyperledger): technical discussions and questions

## 4. Code Commit Steps

Expand Down Expand Up @@ -98,7 +98,7 @@ docs %

Notice you will get a GitHub PR url like `https://github.com/hyperledger/cello/pull/145`, open it and check the status.

After the ci checking passed, add [reviewers](https://wiki.hyperledger.org/projects/cello#contributors) to the reviewer list and also post the GitHub PR url in the [chat channel](https://chat.hyperledger.org/channel/cello). The patch will be merged into the `master` branch after passing the review, then mark the Jira item as `Done`.
After the ci checking passed, add [reviewers](https://wiki.hyperledger.org/projects/cello#contributors) to the reviewer list and also post the GitHub PR url in the chat channel. The patch will be merged into the `master` branch after passing the review, then mark the Jira item as `Done`.

* If you need to refine the patch further as the reviewers may suggest, you can change on the same branch, and commit the new code with `git commit -a --amend`, and then use the `git review` command again.

Expand Down
2 changes: 1 addition & 1 deletion docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ For additional helps, feel free to take the following channels:

* [Wikipage](https://wiki.hyperledger.org/projects/cello): Lots of information and documentation about the project, e.g., meeting schedule, design doc.
* [Mail List](mailto:[email protected]): General technical topics with Cello project.
* [RocketChat Room](https://chat.hyperledger.org/channel/cello): Real-time online discussions.
* [Discord](https://discord.gg/hyperledger): Real-time online discussions.
* [Jira Board](https://jira.hyperledger.org/projects/CE/issues): Find development status, report bug, or help [contribute code](contributing.md).
* [GitHub](https://github.com/hyperledger/cello): Development related code and patchsets, welcome to [contribute](contributing.md).
* [Stack Overflow](https://stackoverflow.com/questions/tagged/hyperledger-cello): Stack overflow discussion questions about cello.
Expand Down

0 comments on commit fdd24f6

Please sign in to comment.