Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(trivy): fix scan failures due to TOOMANYREQUESTS DB error #3659

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aldousalvarez
Copy link
Contributor

Commit to be reviewed


ci(trivy): fix scan failures due to TOOMANYREQUESTS DB error

Primary Changes
----------------
1. Updated the ci.yaml to make the trivy scan 
   run only on the weekends

Fixes #3652

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@outSH
Copy link
Contributor

outSH commented Nov 29, 2024

Looks fine, but I'd rather have a separate "weekly" job triggered by cron (https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#schedule), it will be easier to see and add new weekly jobs, and it doesn't convolute our CI job with more prerequisites. @petermetz any thoughts?

Primary Changes
----------------
1. Updated the ci.yaml to make the trivy scan
   run only on the weekends

Fixes hyperledger-cacti#3652

Signed-off-by: aldousalvarez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci(trivy): fix scan failures due to TOOMANYREQUESTS DB error
2 participants