This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: DI - change verifier interface #3626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishasizov-SK
force-pushed
the
feat_DI_change_verifier
branch
4 times, most recently
from
6bb4682
to
9b43e91
Compare
Codecov Report
@@ Coverage Diff @@
## main #3626 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 367 367
Lines 50024 50029 +5
=======================================
+ Hits 43487 43495 +8
+ Misses 4951 4949 -2
+ Partials 1586 1585 -1
|
Moopli
reviewed
Aug 25, 2023
| "github.com/hyperledger/aries-framework-go/component/models/dataintegrity/models" | ||
| "github.com/hyperledger/aries-framework-go/component/models/dataintegrity/suite" | ||
| "github.com/hyperledger/aries-framework-go/component/models/ld/processor" | ||
| signatureverifier "github.com/hyperledger/aries-framework-go/pkg/doc/signature/verifier" |
There was a problem hiding this comment.
don't import afgo pkg into afgo component, use "github.com/hyperledger/aries-framework-go/component/models/signature/verifier"
Signed-off-by: Mykhailo Sizov <[email protected]>
mishasizov-SK
force-pushed
the
feat_DI_change_verifier
branch
from
9b43e91
to
39b5b15
Compare
Moopli
approved these changes
Aug 28, 2023
fqutishat
approved these changes
Aug 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Data Integrity verifier interface.