This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: added data integrity jsonld context #3624
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Added data integrity JSON-LD context
Description:
Because of the missed DI JSON LD context (and disabled strict validation), Aries on issuance stage generated invalid
canonicalProofConfig
considering onlytype
field.Example:
Verification part was successful because Aries considered same
type
field. And because of that, Unit tests did not catch the typo that on verification stage fieldcreated
was empty.According to Spec, another fields must be also included in
canonicalProofConfig
.After this PR, Aries generates the following
canonicalProofConfig
: