refactor: change xeipuuv/gojsonschema to santhosh-tekuri/jsonschema package #3395
Conversation
Abdulbois
force-pushed
the
replace-gojsonschema-package
branch
3 times, most recently
from
6233891
to
d493945
Compare
…ackage inside verifiable presentation. Refactor related unit tests Signed-off-by: Abdulbois <[email protected]>
Abdulbois
force-pushed
the
replace-gojsonschema-package
branch
from
d493945
to
7e6e5f7
Compare
Codecov Report
@@ Coverage Diff @@
## main #3395 +/- ##
==========================================
+ Coverage 87.98% 87.99% +0.01%
==========================================
Files 332 333 +1
Lines 46051 46093 +42
==========================================
+ Hits 40517 40559 +42
Misses 4099 4099
Partials 1435 1435
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Abdulbois
requested review from
troyronda,
baha-ai,
sudeshrshetty,
rolsonquadras,
ashcherbakov and
kgoncharov
| @@ -49,6 +49,7 @@ require ( | |||
| github.com/pmezard/go-difflib v1.0.0 // indirect | |||
| github.com/pquerna/cachecontrol v0.1.0 // indirect | |||
| github.com/rs/cors v1.7.0 // indirect | |||
| github.com/santhosh-tekuri/jsonschema v1.2.4 // indirect | |||
There was a problem hiding this comment.
is xeipuuv/gojsonschema package still referenced somewhere? I see indirect references at lines 60-62 below.
It would be good to remove all references to xeipuuv packages
There was a problem hiding this comment.
@Baha-sk - @Abdulbois wanted to show one example of the change to gather feedback. Once there is some feedback, all instances will be changed.
There was a problem hiding this comment.
I am for this change. A couple of days ago the old package was failing bbs signature post signing when validating the json map where an embedded json struct was being wrongly resolving to an empty RDF entry. Hopefully, this package does a better job at mapping jsonld docs.
| @@ -72,6 +72,7 @@ require ( | |||
| github.com/pmezard/go-difflib v1.0.0 // indirect | |||
| github.com/pquerna/cachecontrol v0.1.0 // indirect | |||
| github.com/rs/cors v1.7.0 // indirect | |||
| github.com/santhosh-tekuri/jsonschema v1.2.4 // indirect | |||
There was a problem hiding this comment.
same here... lines 86-88 below
Description:
xeipuuv/gojsonschematosanthosh-tekuri/jsonschemapackage insideverifiable presentationRelated to #3393