Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Minor fix in routeguide example #2076

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

arjan-bal
Copy link
Contributor

Motivation

  1. The following logs line prints a feature but the logs mentions NOTE. NOTE messages are printed later in bidirectional stream code, so this may be a copy/paste error.
println!("NOTE = {:?}", feature);
  1. The following line in the markdown file declares tx as mut which and detected by rust-analyzer. The actual client file doesn't declare tx as mut.
let (mut tx, rx) = mpsc::channel(4);

Client code:

let (tx, rx) = mpsc::channel(4);
let features = self.features.clone();

Solution

  1. Make the print statement accurate.
  2. Remove the unnecessary mut.

@tottoto
Copy link
Collaborator

tottoto commented Nov 30, 2024

Thanks.

@tottoto tottoto added this pull request to the merge queue Nov 30, 2024
Merged via the queue into hyperium:master with commit 1442a59 Nov 30, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants