chore(tonic): Deprecate API when they only return None #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tottoto
force-pushed
the
deprecate-api-when-only-return-none
branch
2 times, most recently
from
86a7dce to
f099c76
Compare
tottoto
force-pushed
the
deprecate-api-when-only-return-none
branch
2 times, most recently
from
5a619fc to
5161581
Compare
tottoto
force-pushed
the
deprecate-api-when-only-return-none
branch
from
5161581 to
4bccf74
Compare
LucioFranco
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#1516
Solution
Deprecates
Request::local_addr,Request::remote_addrandRequest::peer_certswhen they only returnNone.