support vectored IO #1502
Merged
support vectored IO #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you need to rebase against master since there are some changes (and force push). This seems like a good thing to implement! |
xiaoyawei
force-pushed
the
vectored_io
branch
from
74b7d15 to
acfea91
Compare
|
@LucioFranco just update the branch, PTAL |
|
hi @LucioFranco when you have time would you mind taking another look at this PR? thanks! |
xiaoyawei
force-pushed
the
vectored_io
branch
from
acfea91 to
d0f58f1
Compare
|
hi @LucioFranco would you take another look at this PR when you have time? Thanks in advance! |
|
hi @LucioFranco when you have time, would you please take another look at this? This PR shall help improve throughput especially for streaming RPCs, since most of the OS now supports vectored I/O |
LucioFranco
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Neither
BoxedIonorServerIohave vectored I/O parts implemented; this make the usages oftoniclose the opportunity to use vectored I/O to optimize performance.Solution
Implement the vectored I/O part by delegating to the underlying Io trait object.