-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zstd compression support #1371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a hyper dev, but approach seems sensible and extensible. I would look into the function visibility comment, though.
@martinabeleda any updates on this CR? Are you waiting for feedback from the actual maintainers? @LucioFranco would you be willing to accept this change? I think this will lead to substantial performance improvement for especially compressible messages. |
@mpetri I just have a few of your comments to address but other than that I'm waiting for maintainers. I'll have some time to finish the PR later today so can try to reach @LucioFranco on discord |
Hi sorry for the delay. I think the comments make sense but I am taking a small break for the next few weeks so the progress has been slow here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good now. One minor comment on the default value of the compressor
Hi @LucioFranco, I have tested it in production, and it works perfectly! Thank you, @martinabeleda! When do you think we can merge it? I don't want to stay on a fork with that patch forever. |
@martinabeleda seems like there are some failures around feature flags in CI. |
@martinabeleda do you have the time to fix the CI issue ? Otherwise I will re-open the PR with your code and the fixes for the CI. |
@QuentinPerez I haven't had time to work on the fixes so would appreciate if you could help fix CI. Thanks!! |
Resolved in #1532. Thank you! |
Motivation
See #1236
Solution
Add zstd as a
CompressionEncoding
and as a feature/optional dependency.New to rust so looking for some feedback on my approach to testing.