chore(server/conn): backport max_pending_accept_reset_streams()
#3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Submitted #3797 to fix that MSRV job. |
thank you! i'll rebase now |
…builder NB: this commit is based on the `0.14.x` release series. the `server::conn::http2` submodule provides types that are conditionally compiled when the `backports` feature is active, to facilitate upgrading to the `1.x` release. i've been working on upgrading the [`linkerd2-proxy`](https://github.com/linkerd/linkerd2-proxy/) project to use hyper 1.0, but encountered some gaps in `Builder<E>`'s interface when setting the `backports` and `deprecated` features. this adds a `max_pending_accept_reset_streams(..)` method (_added in #3201_) to this builder, so that 0.14.x users relying on this functionality can prepare to upgrade to hyper 1.x safely. this is effectively a backport of hyperium#3507, which restored this interface to the 1.0 release. for more information, see: * hyperium#3201 * hyperium#3507 * hyperium#3461 * https://hyper.rs/guides/1/upgrading/ Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/backport-max-pending-accept-reset-streams
branch
from
28f5e67
to
403b2d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: this commit is based on the
0.14.xrelease series.the
server::conn::http2submodule provides types that are conditionally compiled when thebackportsfeature is active, to facilitate upgrading to the1.xrelease.i've been working on upgrading the
linkerd2-proxyproject to use hyper 1.0, but encountered a pertinent gap inBuilder<E>'s interface when setting thebackportsanddeprecatedfeatures.this adds a
max_pending_accept_reset_streams(..)method (added in #3201) to this builder, so that 0.14.x users relying on this functionality can prepare to upgrade to hyper 1.x safely.this is effectively a backport of #3507, which restored this interface to the 1.0 release.
for more information, see:
max_pending_accept_reset_streams#3461