Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version specific prefixes from builders #3101

Conversation

Michael-J-Ward
Copy link
Contributor

@Michael-J-Ward Michael-J-Ward commented Dec 24, 2022

Fixes #3085

Should I also change thet non-public methods in proto::h1::conn?

  • set_http1_header_read_timeout
  • set_h1_parser_config

@Michael-J-Ward Michael-J-Ward force-pushed the remove-version-specific-prefixes-from-builders branch from e936ae4 to b452e78 Compare December 24, 2022 18:45
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks super, thanks so much! I see there's a fixup! commit in the list, did you want to rebase and do the fix locally? The merge button only lets me either rebase merge without interactive mode, or squash it all into a single commit.

@Michael-J-Ward Michael-J-Ward force-pushed the remove-version-specific-prefixes-from-builders branch from 1cefad6 to eed0bbd Compare December 27, 2022 22:28
@Michael-J-Ward
Copy link
Contributor Author

done ✅

@seanmonstar seanmonstar merged commit 27fc9aa into hyperium:master Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove version-specific prefixes from builder methods
3 participants