Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add TowerToHyperService #64

Merged
merged 1 commit into from
Nov 28, 2023
Merged

feat: add TowerToHyperService #64

merged 1 commit into from
Nov 28, 2023

Conversation

davidpdrsn
Copy link
Member

Extracted from #46. This adds TowerToHyperService which converts a tower service into a hyper service. Among other things, this is useful for running axum with hyper.

seanmonstar
seanmonstar approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me!

Any reason we shouldn't make it part of an optional tower feature, like how tokio enables those RT types?

@jplatte
Copy link

jplatte commented Nov 28, 2023

Seems like tower is an unconditional dependency already. But maybe not public?

@TannerRogalsky
Copy link

Once this is merged I'll update the turmoil example.

@seanmonstar seanmonstar merged commit b6bffe2 into master Nov 28, 2023
15 checks passed
@seanmonstar seanmonstar deleted the tower-adapter branch November 28, 2023 22:08
@TannerRogalsky TannerRogalsky mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidpdrsn @jplatte @TannerRogalsky @seanmonstar