Added .with_upgrades() to connection
#38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all honesty, I really don't know if it's possible to have this happen in the same function with a
?Sendway, but I couldn't get that to work. So I added a new function that requires the IO stream to beSend, which automatically upgrades HTTP/1 connections.Also, does HTTP/2 not require upgrades? I was looking for a similar
.with_upgrades()function inself.http2.serve_connection, and when I couldn't find it, I tried adding it, and realized that there was noupgradesmodule at all. Is this inherently present in HTTP/2 or is this just something that we haven't implemented yet?This is required by tokio-rs/axum#2241