DRAFT: disabled two assertions while fuzzing #696
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Rodler <[email protected]>
seanmonstar
reviewed
Jun 20, 2023
| @@ -448,6 +448,7 @@ where | |||
| // This is handled by resetting the frame then trying to read | |||
| // another frame. | |||
| Err(Error::Reset(id, reason, initiator)) => { | |||
| #[cfg(not(fuzzing))] | |||
| debug_assert_eq!(initiator, Initiator::Library); | |||
There was a problem hiding this comment.
@nox do you recall why this is asserted? If it's Remote, should something else be done? This is getting trigger in fuzzing.
There was a problem hiding this comment.
It is done because from my understanding of the code back then this path should never be taken with Initiator::Remote, can you repro how it does happen?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.