[PATCH] Follow XDG Base Directory spec on Linux #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses QStandardPaths to get cache, data and config XDG folders. The config file go to $XDG_CONFIG_HOME/hydrogen/hydrogen.conf The cache folder go to $XDG_CACHE_HOME/hydrogen/ And all the data subfolders (drumkits, plugins, playlists, etc.) go to $XDG_DATA_HOME/hydrogen/ along with the hydrogen.log file. If old folder (~/.hydrogen/) is found, use that instead of the XDG paths. The __usr_*_paths are setted outside a function, so QStandardPaths isn't avaliable to get the XDG paths. Also no APPNAME is avaliable until setApplicationName() is called after the Filesystem::check_usr_paths() is used. To avoid this update_usr_paths() is added at the begining of check_usr_paths() to update the correct values from QStandardPaths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #643. Uses QStandardPaths to get cache, data and config XDG folders only on Linux. If old folder (e.g.
~/.hydrogen/) is found, use that instead of the XDG paths. If no folder is found, create the XDG dirs.According to https://doc.qt.io/qt-5/qstandardpaths.html this should be the default paths returned by QStandardPaths (Follow the ENV paths configured by the user):
The
__usr_*_pathsare setted outside a function, so QStandardPaths isn't avaliable to get the XDG paths. Also no APPNAME is avaliable until setApplicationName() is called after theFilesystem::check_usr_paths()is used. To avoid thisupdate_usr_paths()is added at the begining ofcheck_usr_paths()to update the correct values from QStandardPaths.