Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix main window maximizing from splash #504

Merged
merged 7 commits into from
May 26, 2024
Merged

Conversation

Kadu-H
Copy link
Contributor

@Kadu-H Kadu-H commented May 24, 2024

The code checks whether the initial window starts maximized, if so, prevents the splash from starting maximized and leaves the main window maximized.

Kadu-H added 2 commits May 24, 2024 12:46
The code checks whether the initial window is maximized, if so, it leaves the main window also maximized.
The code checks whether the initial window starts maximized, if so, prevents the splash from starting maximized and leaves the main window maximized.
@zamitto
Copy link
Collaborator

zamitto commented May 25, 2024

I get your idea, I will just propose a few changes

src/main/services/window-manager.ts Outdated Show resolved Hide resolved
src/main/services/window-manager.ts Outdated Show resolved Hide resolved
src/main/services/window-manager.ts Show resolved Hide resolved
Kadu-H added 2 commits May 25, 2024 19:18
The code checks whether the initial window starts maximized; If so, it prevents the splash from starting maximized and leaves the main window maximized.
The code checks whether the initial window starts maximized; If so, it prevents the splash from starting maximized and leaves the main window maximized.
@Kadu-H Kadu-H requested a review from zamitto May 25, 2024 22:29
Kadu-H and others added 3 commits May 25, 2024 19:29
The code checks whether the initial window starts maximized; If so, it prevents the splash from starting maximized and leaves the main window maximized.
Copy link
Collaborator

@zamitto zamitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zamitto zamitto merged commit 21305d3 into hydralauncher:main May 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants