Skip to content

Commit

Permalink
Deflake test ync should continue if not all slaves dropped dual-chann…
Browse files Browse the repository at this point in the history
…el-replication (valkey-io#1164)

Sometimes when dual-channel is turned off the tested replica might
disconnect on COB overrun. disable the replica COB limit in order to
prevent such cases.

Fixes: valkey-io#1153

Signed-off-by: Ran Shidlansik <[email protected]>
Signed-off-by: Binbin <[email protected]>
Co-authored-by: Binbin <[email protected]>
  • Loading branch information
ranshid and enjoy-binbin authored Oct 14, 2024
1 parent 597aa03 commit 36d438b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/integration/dual-channel-replication.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -842,11 +842,11 @@ start_server {tags {"dual-channel-replication external:skip"}} {
$primary config set dual-channel-replication-enabled yes
$primary config set loglevel debug
$primary config set repl-diskless-sync-delay 5

$primary config set client-output-buffer-limit "replica 0 0 0"

# Generating RDB will cost 5s(10000 * 0.0005s)
$primary debug populate 10000 primary 1
$primary config set rdb-key-save-delay 500

$primary config set dual-channel-replication-enabled $dualchannel

start_server {} {
Expand Down

0 comments on commit 36d438b

Please sign in to comment.