Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add duplication validate API #38

Merged
merged 1 commit into from
Jun 26, 2024
Merged

feat: Add duplication validate API #38

merged 1 commit into from
Jun 26, 2024

Conversation

hv0905
Copy link
Owner

@hv0905 hv0905 commented Jun 26, 2024

  • feat: Add duplication validate API
  • fix: Return validation error when querying advance search with no positive criteria
  • fix: Add response type annotations for some API in Admin router
  • test: Add test to ensure the id consistency across versions

- fix: Return validation error when querying advance search with no positive criteria
- fix: Add response type annotations for some API in Admin router
- test: Add test to ensure the id consistency across versions
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working enhancement New feature or request test Changes related to testing labels Jun 26, 2024
Copy link

codeclimate bot commented Jun 26, 2024

Code Climate has analyzed commit dd8d0d3 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.31%. Comparing base (2648e51) to head (dd8d0d3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   79.48%   80.31%   +0.83%     
==========================================
  Files          29       29              
  Lines        1272     1280       +8     
==========================================
+ Hits         1011     1028      +17     
+ Misses        261      252       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hv0905 hv0905 merged commit a4fdb86 into master Jun 26, 2024
8 checks passed
@hv0905 hv0905 deleted the dup_validate branch June 26, 2024 12:49
@pk5ls20 pk5ls20 removed the bug Something isn't working label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files. test Changes related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants