Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting thumbnail mode when uploading #32

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Allow setting thumbnail mode when uploading #32

merged 3 commits into from
Jun 4, 2024

Conversation

hv0905
Copy link
Owner

@hv0905 hv0905 commented Jun 4, 2024

This allow users to create an local thumbnail even if the image isn't a local image.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.93%. Comparing base (799d6e1) to head (d87b2c0).

Files Patch % Lines
app/Controllers/admin.py 90.00% 1 Missing ⚠️
app/Controllers/search.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   76.41%   78.93%   +2.51%     
==========================================
  Files          29       29              
  Lines        1238     1253      +15     
==========================================
+ Hits          946      989      +43     
+ Misses        292      264      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jun 4, 2024
Copy link

codeclimate bot commented Jun 4, 2024

Code Climate has analyzed commit d87b2c0 and detected 0 issues on this pull request.

View more on Code Climate.

@hv0905 hv0905 merged commit 43d30ab into master Jun 4, 2024
8 checks passed
@hv0905 hv0905 deleted the thumbnail branch June 4, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant