-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic implementation of storage service #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make pylint ignore `import-error,no-name-in-module` only in files imported into opendal and not globally
# Conflicts: # config/default.env
@pk5ls20 Pls review recent changes |
pk5ls20
commented
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@hv0905 Pls review recent changes |
hv0905
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the storage-related parts of the project into StorageService, which interfaces with opendal, an efficient data access layer. Currently, the PR has implemented local storage and S3 compatible API storage.
Why use S3 compatible APIs?
S3 compatible APIs are supported by many cloud storage platforms, including but not limited to Amazon S3, CloudFlare R2, Tencent Cloud COS, and Minio among others.
Breaking change
After this PR, the
APP_STATIC_FILE__*
configurations in the configuration file are deprecated, and new configuration itemsAPP_STORAGE__*
have been introduced.