Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic implementation of storage service #14

Merged
merged 8 commits into from
Apr 26, 2024
Merged

Basic implementation of storage service #14

merged 8 commits into from
Apr 26, 2024

Conversation

pk5ls20
Copy link
Collaborator

@pk5ls20 pk5ls20 commented Feb 8, 2024

Description

This PR refactors the storage-related parts of the project into StorageService, which interfaces with opendal, an efficient data access layer. Currently, the PR has implemented local storage and S3 compatible API storage.

Why use S3 compatible APIs?

S3 compatible APIs are supported by many cloud storage platforms, including but not limited to Amazon S3, CloudFlare R2, Tencent Cloud COS, and Minio among others.

Breaking change

After this PR, the APP_STATIC_FILE__* configurations in the configuration file are deprecated, and new configuration items APP_STORAGE__* have been introduced.

@pk5ls20 pk5ls20 requested a review from hv0905 February 8, 2024 08:59
@hv0905 hv0905 added enhancement New feature or request breaking changes labels Feb 8, 2024
hv0905 and others added 5 commits February 9, 2024 15:59
- Make pylint ignore `import-error,no-name-in-module` only in files imported into opendal and not globally
# Conflicts:
#	config/default.env
@hv0905
Copy link
Owner

hv0905 commented Apr 26, 2024

@pk5ls20 Pls review recent changes

Copy link
Collaborator Author

@pk5ls20 pk5ls20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pylintrc.toml Outdated Show resolved Hide resolved
app/Services/storage/s3_compatible_storage.py Outdated Show resolved Hide resolved
@pk5ls20
Copy link
Collaborator Author

pk5ls20 commented Apr 26, 2024

@hv0905 Pls review recent changes

@pk5ls20 pk5ls20 merged commit f96a420 into master Apr 26, 2024
4 checks passed
@hv0905 hv0905 deleted the feat/storage branch April 26, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants