Try mutation testing

.github/workflows/tests.yaml

@@ -0,0 +1,21 @@
+name: Run tests
+on: [ push ]
+jobs:
+    run-mutation-tests:
+        runs-on: ubuntu-latest
+        steps:
+            -   name: Checkout sources
+                uses: actions/checkout@v3
+
+            -   name: Setup PHP
+                uses: shivammathur/setup-php@v2
+                with:
+                    php-version: '8.1'
+                    tools: composer:v2
+                    coverage: xdebug
+
+            -   name: Composer install
+                run: composer install
+
+            -   name: Run mutation tests
+                run: vendor/bin/infection --show-mutations

.travis.yml

@@ -4,8 +4,7 @@ env:
   - XDEBUG_MODE=coverage
 
 php:
-  - 7.4
-  - 8.0
+  - 8.1
 
 before_script:
   - travis_retry composer self-update

composer.json

@@ -11,11 +11,12 @@
   ],
   "minimum-stability": "stable",
   "require": {
-    "php": "^7.4|^8.0",
+    "php": ">=8.1",
     "ext-json": "*"
   },
   "require-dev": {
-    "phpunit/phpunit": "^9.5"
+    "phpunit/phpunit": "^9.5",
+    "infection/infection": "^0.26.16"
   },
   "autoload": {
     "psr-4": {
@@ -26,5 +27,10 @@
     "psr-4": {
       "hunomina\\DataValidator\\Test\\": "tests/"
     }
+  },
+  "config": {
+    "allow-plugins": {
+      "infection/extension-installer": true
+    }
   }
 }

infection.json

@@ -0,0 +1,13 @@
+{
+    "$schema": "vendor/infection/infection/resources/schema.json",
+    "source": {
+        "directories": [
+            "src"
+        ]
+    },
+    "mutators": {
+        "@default": true,
+        "Concat": false,
+        "ConcatOperandRemoval": false
+    }
+}

phpunit.xml

@@ -8,6 +8,8 @@
          forceCoversAnnotation="true"
          stderr="true"
          verbose="true"
+         executionOrder="random"
+         resolveDependencies="true"
 >
     <coverage processUncoveredFiles="true">
         <include>

src/Data/Json/JsonData.php

@@ -89,7 +89,7 @@ public function offsetExists($offset): bool
      * @return mixed|null
      * @codeCoverageIgnore
      */
-    public function offsetGet($offset)
+    public function offsetGet($offset): mixed
     {
         if ($this->offsetExists($offset)) {
             return $this->data[$offset];

src/Rule/Json/Check/DateFormatCheckTrait.php

@@ -31,7 +31,7 @@ public function setDateFormat(?string $dateFormat): void
      * @return bool
      * Return true if the string data match the date format $this->dateFormat
      */
-    public function validateDateFormat(string $data): bool
+    private function validateDateFormat(string $data): bool
     {
         if ($this->dateFormat === null) {
             return true;

src/Rule/Json/Check/EmptyCheckTrait.php

@@ -30,5 +30,5 @@ public function setEmpty(bool $empty): void
      * Return true if the value is "empty" (string, list) and can
      * Or if the value is not empty
      */
-    abstract public function validateEmptiness($data): bool;
-}
+    abstract private function validateEmptiness($data): bool;
+}

src/Rule/Json/Check/EnumCheckTrait.php

@@ -35,7 +35,7 @@ public function setEnum(?array $enum): void
      * @return bool
      * Return true if the data can be found in $this->enum
      */
-    public function validateEnum($data): bool
+    private function validateEnum($data): bool
     {
         if ($this->enum === null) {
             return true;

src/Rule/Json/Check/LengthCheckTrait.php

@@ -35,5 +35,5 @@ public function setLength(?int $length): void
      * @return bool
      * Return true if the data length (regardless of the type, could be a string, an array, ...) equals $this->length
      */
-    abstract public function validateLength($data): bool;
+    abstract private function validateLength($data): bool;
 }

src/Rule/Json/Check/MaximumCheckTrait.php

@@ -29,5 +29,5 @@ public function setMaximum(?float $maximum): void
      * Return true if the value is lower or equals to $this->maximum
      * For integer check => Cast the parameter
      */
-    abstract public function validateMaximum($data): bool;
+    abstract private function validateMaximum($data): bool;
 }

src/Rule/Json/Check/MinimumCheckTrait.php

@@ -29,5 +29,5 @@ public function setMinimum(?float $minimum): void
      * Return true if the value is greater or equals to $this->minimum
      * For integer check => Cast the parameter
      */
-    abstract public function validateMinimum($data): bool;
+    abstract private function validateMinimum($data): bool;
 }

src/Rule/Json/Check/PatternCheckTrait.php

@@ -30,7 +30,7 @@ public function setPattern(?string $pattern): void
      * Return true if the string data match the pattern
      * Regular expressions only apply to string that's why this method is not abstract
      */
-    public function validatePattern(string $data): bool
+    private function validatePattern(string $data): bool
     {
         if ($this->pattern === null) {
             return true;

src/Rule/Json/Factory/JsonRuleFactory.php

@@ -32,7 +32,7 @@ public static function create(string $type, array $options): JsonRule
     {
         try {
             $rule = self::getRuleObjectFromType($type);
-        } catch (InvalidRuleException $e) {
+        } catch (InvalidRuleException) {
             throw new InvalidRuleException('Invalid rule type : `' . $type . '`', InvalidRuleException::INVALID_RULE_TYPE);
         }
 

src/Rule/Json/FloatRule.php

@@ -52,7 +52,7 @@ public function validate($data): bool
      * @param $data
      * @return bool
      */
-    public function validateMaximum($data): bool
+    private function validateMaximum($data): bool
     {
         if ($this->maximum === null) {
             return true;
@@ -65,7 +65,7 @@ public function validateMaximum($data): bool
      * @param $data
      * @return bool
      */
-    public function validateMinimum($data): bool
+    private function validateMinimum($data): bool
     {
         if ($this->minimum === null) {
             return true;

src/Rule/Json/IntegerRule.php

@@ -52,7 +52,7 @@ public function validate($data): bool
      * @param $data
      * @return bool
      */
-    public function validateMaximum($data): bool
+    private function validateMaximum($data): bool
     {
         if ($this->maximum === null) {
             return true;
@@ -65,7 +65,7 @@ public function validateMaximum($data): bool
      * @param $data
      * @return bool
      */
-    public function validateMinimum($data): bool
+    private function validateMinimum($data): bool
     {
         if ($this->minimum === null) {
             return true;

src/Rule/Json/NumericRule.php

@@ -52,7 +52,7 @@ public function validate($data): bool
      * @param float $data
      * @return bool
      */
-    public function validateMaximum($data): bool
+    private function validateMaximum($data): bool
     {
         if ($this->maximum === null) {
             return true;
@@ -65,7 +65,7 @@ public function validateMaximum($data): bool
      * @param float $data
      * @return bool
      */
-    public function validateMinimum($data): bool
+    private function validateMinimum($data): bool
     {
         if ($this->minimum === null) {
             return true;

src/Rule/Json/StringRule.php

@@ -64,7 +64,7 @@ public function validate($data): bool
      * @param $data
      * @return bool
      */
-    public function validateEmptiness($data): bool
+    private function validateEmptiness($data): bool
     {
         if ($this->empty === false) { // can not be an empty value
             return $data !== '';
@@ -77,7 +77,7 @@ public function validateEmptiness($data): bool
      * @param $data
      * @return bool
      */
-    public function validateLength($data): bool
+    private function validateLength($data): bool
     {
         if ($this->length === null) {
             return true;
@@ -93,4 +93,4 @@ public function getType(): string
     {
         return self::STRING_TYPE;
     }
-}
+}

src/Rule/Json/TypedListRule.php

@@ -26,11 +26,8 @@ class TypedListRule extends JsonRule
     use EnumCheckTrait;
     use EmptyCheckTrait;
 
-    private JsonRule $childRule;
-
-    public function __construct(JsonRule $childRule)
+    public function __construct(private JsonRule $childRule)
     {
-        $this->childRule = $childRule;
     }
 
     /**
@@ -81,7 +78,7 @@ public function validate($data): bool
     /**
      * @inheritDoc
      */
-    public function validateEmptiness($data): bool
+    private function validateEmptiness($data): bool
     {
         if (($this->empty === false) && $this->minimum !== 0) {
             return count($data) !== 0;
@@ -106,7 +103,7 @@ public function setLength(?int $length): void
     /**
      * @inheritDoc
      */
-    public function validateLength($data): bool
+    private function validateLength($data): bool
     {
         if ($this->length === null) {
             return true;
@@ -131,7 +128,7 @@ public function setMaximum(?float $maximum): void
      * @param array $data
      * @return bool
      */
-    public function validateMaximum($data): bool
+    private function validateMaximum($data): bool
     {
         if ($this->maximum === null) {
             return true;
@@ -156,7 +153,7 @@ public function setMinimum(?float $minimum): void
      * @param array $data
      * @return bool
      */
-    public function validateMinimum($data): bool
+    private function validateMinimum($data): bool
     {
         if ($this->minimum === null) {
             return true;
@@ -180,4 +177,4 @@ public function getType(): string
     {
         return $this->childRule->getType() . self::LIST_TYPE_SUFFIX;
     }
-}
+}

src/Schema/Json/JsonSchema.php

@@ -207,6 +207,7 @@ private function validateObject(JsonData $dataType): bool
                     } catch (InvalidDataException $e) {
                         throw new InvalidDataException('`' . $field . '` does not validate the schema. ' . $e->getMessage(), $e->getCode(), $e);
                     }
+                    break;
                 }
             }