Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #523: Global calendar: display the "My profile" filter only when … #524

Closed
wants to merge 12 commits into from

Conversation

marc-farre
Copy link
Contributor

…the module is enabled in for the User account

Issue #523

…the module is enabled in for the User account
Copy link
Contributor

@luke- luke- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marc-farre Thanks!

Can you please adjust the tests to this PR?

@marc-farre
Copy link
Contributor Author

@luke- I have fixed the test issue. But I cannot make self tests work now, for none of the PR:

On my local computer, with HH core master branch, all tests are passing.
Any idea?

@luke-
Copy link
Contributor

luke- commented Jan 23, 2025

@marc-farre Did you checked the screenshot from the failing step?

https://github.com/humhub/calendar/actions/runs/12929178000/job/36058022048?pr=524#step:27:28

@marc-farre
Copy link
Contributor Author

@luke- Thanks.
Now it's OK for #527
But I cannot make this PR work.

The issue is on $I->cantSee('Space Event', '#calendar');
But I can see it:
image

image

And I don't understand how it can be related to the changes.

I also tried to merge #527 into this one, but still doesn't work.

So once #527 is merged, I will create a new PR for this fix, and we'll see if it works better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants