Remove unused pallet-base-fee and pallet-dynamic-fee deps (#737)

* Remove unused pallet-base-fee and pallet-dynamic-fee deps * Update features snapshot * Update help output
humanode-network · Aug 21, 2023 · 362d0ed · 362d0ed
1 parent ab058ce
commit 362d0ed
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 84 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/humanode-peer/src/cli/config.rs b/crates/humanode-peer/src/cli/config.rs
@@ -80,11 +80,6 @@ pub trait CliConfigurationExt: SubstrateCliConfigurationProvider {
         None
     }
 
-    /// Provide the evm params, if available.
-    fn evm_params(&self) -> Option<&params::EvmParams> {
-        None
-    }
-
     /// Provide the Ethereum RPC params.
     fn ethereum_rpc_params(&self) -> Option<&params::EthereumRpcParams> {
         None

diff --git a/crates/humanode-peer/src/cli/params.rs b/crates/humanode-peer/src/cli/params.rs
@@ -51,14 +51,6 @@ pub struct BioauthFlowParams {
     pub robonode_url: Option<String>,
 }
 
-/// Shared CLI parameters used to configure EVM.
-#[derive(Debug, clap::Parser, Clone)]
-pub struct EvmParams {
-    /// The dynamic-fee pallet target gas price set by block author.
-    #[arg(long, default_value = "1")]
-    pub target_gas_price: u64,
-}
-
 /// Shared CLI parameters used to configure Ethereum RPC.
 #[derive(Debug, clap::Parser, Clone)]
 pub struct EthereumRpcParams {

diff --git a/crates/humanode-peer/src/cli/run_cmd.rs b/crates/humanode-peer/src/cli/run_cmd.rs
@@ -15,10 +15,6 @@ pub struct RunCmd {
     #[command(flatten)]
     pub bioauth_flow_params: params::BioauthFlowParams,
 
-    #[allow(missing_docs, clippy::missing_docs_in_private_items)]
-    #[command(flatten)]
-    pub evm_params: params::EvmParams,
-
     #[allow(missing_docs, clippy::missing_docs_in_private_items)]
     #[command(flatten)]
     pub ethereum_rpc_params: params::EthereumRpcParams,
@@ -41,10 +37,6 @@ impl CliConfigurationExt for RunCmd {
         Some(&self.bioauth_flow_params)
     }
 
-    fn evm_params(&self) -> Option<&params::EvmParams> {
-        Some(&self.evm_params)
-    }
-
     fn ethereum_rpc_params(&self) -> Option<&params::EthereumRpcParams> {
         Some(&self.ethereum_rpc_params)
     }

diff --git a/crates/humanode-runtime/Cargo.toml b/crates/humanode-runtime/Cargo.toml
@@ -56,8 +56,6 @@ libsecp256k1 = { version = "0.7", default-features = false }
 pallet-authorship = { default-features = false, git = "https://github.com/humanode-network/substrate", branch = "locked/polkadot-v0.9.38" }
 pallet-babe = { default-features = false, git = "https://github.com/humanode-network/substrate", branch = "locked/polkadot-v0.9.38" }
 pallet-balances = { default-features = false, git = "https://github.com/humanode-network/substrate", branch = "locked/polkadot-v0.9.38" }
-pallet-base-fee = { default-features = false, git = "https://github.com/humanode-network/frontier", branch = "locked/polkadot-v0.9.38" }
-pallet-dynamic-fee = { default-features = false, git = "https://github.com/humanode-network/frontier", branch = "locked/polkadot-v0.9.38" }
 pallet-ethereum = { default-features = false, git = "https://github.com/humanode-network/frontier", branch = "locked/polkadot-v0.9.38" }
 pallet-evm = { default-features = false, git = "https://github.com/humanode-network/frontier", branch = "locked/polkadot-v0.9.38" }
 pallet-evm-balances = { default-features = false, git = "https://github.com/humanode-network/frontier", branch = "locked/polkadot-v0.9.38" }
@@ -161,13 +159,11 @@ std = [
   "pallet-babe/std",
   "pallet-balanced-currency-swap-bridges-initializer/std",
   "pallet-balances/std",
-  "pallet-base-fee/std",
   "pallet-bioauth/std",
   "pallet-bootnodes/std",
   "pallet-chain-properties/std",
   "pallet-chain-start-moment/std",
   "pallet-currency-swap/std",
-  "pallet-dynamic-fee/std",
   "pallet-ethereum-chain-id/std",
   "pallet-ethereum/std",
   "pallet-evm-accounts-mapping/std",
@@ -230,13 +226,11 @@ try-runtime = [
   "pallet-babe/try-runtime",
   "pallet-balanced-currency-swap-bridges-initializer/try-runtime",
   "pallet-balances/try-runtime",
-  "pallet-base-fee/try-runtime",
   "pallet-bioauth/try-runtime",
   "pallet-bootnodes/try-runtime",
   "pallet-chain-properties/try-runtime",
   "pallet-chain-start-moment/try-runtime",
   "pallet-currency-swap/try-runtime",
-  "pallet-dynamic-fee/try-runtime",
   "pallet-ethereum-chain-id/try-runtime",
   "pallet-ethereum/try-runtime",
   "pallet-evm-accounts-mapping/try-runtime",

diff --git a/utils/checks/snapshots/features.yaml b/utils/checks/snapshots/features.yaml
@@ -931,9 +931,6 @@
   features:
     - default
     - std
-- name: fp-dynamic-fee 1.0.0
-  features:
-    - std
 - name: fp-ethereum 1.0.0-dev
   features:
     - default
@@ -1979,9 +1976,6 @@
   features:
     - default
     - std
-- name: pallet-base-fee 1.0.0
-  features:
-    - std
 - name: pallet-bioauth 0.1.0
   features:
     - default
@@ -2006,9 +2000,6 @@
   features:
     - default
     - std
-- name: pallet-dynamic-fee 4.0.0-dev
-  features:
-    - std
 - name: pallet-ethereum 4.0.0-dev
   features:
     - std

diff --git a/utils/e2e-tests/bash/fixtures/help.stdout.txt b/utils/e2e-tests/bash/fixtures/help.stdout.txt
@@ -630,11 +630,6 @@ Options:
       --robonode-url <ROBONODE_URL>
           The URL of robonode to authenticate with
 
-      --target-gas-price <TARGET_GAS_PRICE>
-          The dynamic-fee pallet target gas price set by block author
-
-          [default: 1]
-
       --max-past-logs <MAX_PAST_LOGS>
           Maximum number of logs to keep from the latest block; it is not possible to query logs older than this amount from the latest block in the past