-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle migrating from WP SEO to Yoast SEO #84
Conversation
Fixes #56 Handles the title options settings and post meta.
Just need to do some more testing but I think is ready more or less. |
Good to go here, tested all the title settings and post meta migration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple questions before merging but I don't think any really block anything:
- This covers Yoast SEO...what about other parts of our SEO module? E.g. Redirects. Will/should that be handled in separate tickets for those plugins?
- This seems like it could be a potentially long script on large sites. Have you tested/timed a full migration?
- I don't see any docs on the migration. Should that be handled in a separate ticket or part of the definition of done for this one?
It’s a good question but as we’re not bundling Yoast Premium yet it’s perhaps not essential but a nice to have. I’ll look at how easy that is when I’m back. It could indeed be a long running script if there’s a lot of customised posts but to be honest I haven’t seen a site making heavy use of SEO post meta that wasn’t already using Yoast. Worth having a further look though in case the meta keys exist with empty values as that would take forever. i didn’t think about docs specifically, figured that would come under the existing docs for the migrate command and what will be in the upgrade guide. Which is something we should write up ASAP 🤔 |
All that sounds good to me. I will create a ticket for at least the seo migration docs (unless we have an existing ticket for migration docs generally that I could tack that onto) and add a note in the redirect ticket that a migration script for that might be needed as well. I will approve & merge after I do that stuff. |
Redirect migration is already part of #59. |
Fixes #56
Handles the title options settings and post meta.