fix: resource definition test #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszjenek
force-pushed
the
fix_resource_definition_test
branch
from
19ddcb2 to
91dd0d9
Compare
| configCreate: func() string { | ||
| return testAccResourceDefinitionS3taticResourceWithSecrets("accessKeyId1", "secretAccessKey1") | ||
| }, | ||
| resourceAttrNameIDValue: "s3-test-with-secrets", |
There was a problem hiding this comment.
I wonder if we should parameterize the resource name here. There is also a long standing issue that occasionally parallel tests affect each other and I guess using a random suffix would fix this and prevent parallel clashes.
mateuszjenek
force-pushed
the
fix_resource_definition_test
branch
from
91dd0d9 to
ee3c8ed
Compare
johanneswuerbach
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.