fix: agent id change requires recreate #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delca85
reviewed
Apr 29, 2024
| @@ -57,6 +59,9 @@ func (*Agent) Schema(ctx context.Context, req resource.SchemaRequest, resp *reso | |||
| "id": schema.StringAttribute{ | |||
| MarkdownDescription: "The ID of the Agent.", | |||
| Required: true, | |||
| PlanModifiers: []planmodifier.String{ | |||
There was a problem hiding this comment.
Does this mean that the agent with the old id is removed?
There was a problem hiding this comment.
Yes, RequiresReplace indicates that this attribute can't be updated in-place and instead the old one needs to be deleted and a new resource needs to be created.
We also use this for example for applications: https://github.com/humanitec/terraform-provider-humanitec/blob/main/internal/provider/resource_application.go#L69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the agent id requires the agent resource to be recreated.