Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rds resource #9

Merged
merged 1 commit into from
Jan 4, 2024
Merged

feat: add rds resource #9

merged 1 commit into from
Jan 4, 2024

Conversation

mateuszjenek
Copy link
Contributor

No description provided.

@dharsanb dharsanb force-pushed the basic_rds_resource branch 2 times, most recently from cd106ab to 58942c5 Compare December 29, 2023 17:09
@mateuszjenek mateuszjenek force-pushed the basic_rds_resource branch 8 times, most recently from f046f6a to e36f020 Compare January 2, 2024 18:45
@mateuszjenek mateuszjenek marked this pull request as ready for review January 2, 2024 18:47
@mateuszjenek mateuszjenek requested a review from a team as a code owner January 2, 2024 18:47
@mateuszjenek mateuszjenek force-pushed the basic_rds_resource branch 5 times, most recently from b780c72 to e5cde62 Compare January 4, 2024 08:44
Copy link
Contributor

@johanneswuerbach johanneswuerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor doc comments, otherwise 👍

examples/rds/basic-postgres/variables.tf Outdated Show resolved Hide resolved
examples/rds/basic-postgres/variables.tf Outdated Show resolved Hide resolved
examples/rds/basic-mysql/variables.tf Outdated Show resolved Hide resolved
examples/rds/basic-mysql/variables.tf Outdated Show resolved Hide resolved
@mateuszjenek mateuszjenek merged commit c52309d into main Jan 4, 2024
1 check passed
@mateuszjenek mateuszjenek deleted the basic_rds_resource branch January 4, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants