Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: split rds res def #15

Merged
merged 1 commit into from
Feb 12, 2024
Merged

chore: split rds res def #15

merged 1 commit into from
Feb 12, 2024

Conversation

johanneswuerbach
Copy link
Contributor

Split the rds resource definition into one for mysql and one for postgres with the respective defaults for the database type so they are easier to use from the outside.

@johanneswuerbach johanneswuerbach requested a review from a team as a code owner February 9, 2024 11:42
mateuszjenek
mateuszjenek approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@mateuszjenek mateuszjenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johanneswuerbach johanneswuerbach merged commit e0c723e into humanitec-architecture:main Feb 12, 2024
1 check passed
@johanneswuerbach johanneswuerbach deleted the split-rds-res-def branch February 12, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszjenek mateuszjenek mateuszjenek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanneswuerbach @mateuszjenek