Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: output aks_cluster_issuer_url #12

Merged

Conversation

johanneswuerbach
Copy link
Contributor

Return the AKS oidc_issuer_url so its easier to access as its required to configure resource.

@johanneswuerbach johanneswuerbach requested a review from a team as a code owner March 18, 2024 12:20
Copy link
Contributor

@astromechza astromechza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i was wondering whether we needed the aks_ prefix, but I see it follows the same pattern of the similar module outputs.

@johanneswuerbach johanneswuerbach merged commit 1b183ed into humanitec-architecture:main Mar 18, 2024
1 check passed
@johanneswuerbach johanneswuerbach deleted the cluster-issuer branch March 18, 2024 22:33
ssalvatori-tw added a commit to ssalvatori-tw/reference-architecture-azure that referenced this pull request Apr 15, 2024
…luster-issuer

feat: output aks_cluster_issuer_url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants