Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(infra): convert to yarn instead of npm #93

Merged
merged 2 commits into from
Apr 23, 2021
Merged

chore(infra): convert to yarn instead of npm #93

merged 2 commits into from
Apr 23, 2021

Conversation

lkipke
Copy link
Contributor

@lkipke lkipke commented Apr 22, 2021 •
edited
Loading

Change summary

Closes #65. Uses yarn import (docs) to generate the lock file.

Also, now that npm is on a new major version that completely rewrites the package-lock.json, I suspect that we're going to start seeing a lot more unintentional diffs (such as in #90), which will be resolved if we just don't use npm at all 💡

@lkipke lkipke added enhancement New feature or request dependencies Pull requests that update a dependency file documentation labels Apr 22, 2021
@lkipke lkipke requested review from sjbarag and alimnios72 April 22, 2021 16:53
@lkipke lkipke self-assigned this Apr 22, 2021
alimnios72
alimnios72 approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@alimnios72 alimnios72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks

@lkipke lkipke merged commit a2902dc into hulu:main Apr 23, 2021
@lkipke lkipke deleted the convert-to-yarn branch April 23, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimnios72 alimnios72 alimnios72 approved these changes

@sjbarag sjbarag Awaiting requested review from sjbarag

Assignees

@lkipke lkipke

Labels
dependencies Pull requests that update a dependency file documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert to yarn instead of npm
2 participants
@lkipke @alimnios72