Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #76 add cleaning testData before running each test file. #88

Merged
merged 8 commits into from
May 18, 2021
Merged

Issue #76 add cleaning testData before running each test file. #88

merged 8 commits into from
May 18, 2021

Conversation

Vasya-M
Copy link
Contributor

@Vasya-M Vasya-M commented Apr 13, 2021 •
edited
Loading

fix for issue #76
added _brs_.testData to docs.
linked brs PR: sjbarag/brs#646

@Vasya-M Vasya-M mentioned this pull request Apr 13, 2021
Merged
@Vasya-M
Copy link
Contributor Author

Vasya-M commented Apr 13, 2021

npm run buildfails cuz brs's PR with the second part where we exportresetTestData is not merged yet

@Vasya-M Vasya-M changed the title add cleaning testData before running each test file. Issue #76 add cleaning testData before running each test file. Apr 14, 2021
lkipke
lkipke suggested changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@lkipke lkipke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Can we add a test case, too? We can do something similar to this test case, where we check that _brs_.testData is not spread across files:

roca/test/before-after/mixed/tests/02-single-level.test.brs

Line 37 in 848a439

m.assert.isInvalid(m.counterB, "afterEach state must not spread to sibling suites")

src/runner/JestRunner.ts Outdated Show resolved Hide resolved
@lkipke lkipke requested review from sjbarag and alimnios72 April 14, 2021 22:38
@Vasya-M Vasya-M requested a review from lkipke April 19, 2021 09:41
lkipke
lkipke approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@lkipke lkipke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, great work!

test/before-after/mixed/tests/02-single-level.test.brs Outdated Show resolved Hide resolved
test/before-after/mixed/tests/01-nested.test.brs Outdated Show resolved Hide resolved
alimnios72
alimnios72 approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@alimnios72 alimnios72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, we just need to wait on the other PR to merge this 🎉

sjbarag pushed a commit to sjbarag/brs that referenced this pull request Apr 30, 2021
@Vasya-M
feat(extensions): Add _brs_.testData associative array (#646)
3afccef 
supports hulu/roca#88
fixes #623
@Vasya-M Vasya-M requested a review from lkipke May 18, 2021 18:10
@lkipke lkipke merged commit a447916 into hulu:main May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkipke lkipke lkipke approved these changes

@alimnios72 alimnios72 alimnios72 approved these changes

@sjbarag sjbarag Awaiting requested review from sjbarag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vasya-M @alimnios72 @lkipke