Conditional Gets #61
Open
Conditional Gets #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(where etag = sha in request)
|
And in the future I should really squash some commits |
| @@ -624,6 +624,28 @@ def test_allowed_methods(self): | |||
| with self.cors_enabled: | |||
| self.assert_header_equal('Access-Control-Allow-Methods', 'HEAD, OPTIONS, GET') | |||
|
|
|||
| class ConditionalGetTestCase(_RestfulGitTestCase): | |||
| cache_control = 'max-age=60' | |||
| def cget_helper(self, url, guess=None): | |||
There was a problem hiding this comment.
I would probably split this into 3 test methods, one per GET request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a conditional decorator from http://flask.pocoo.org/snippets/95/ and adapted it to fit within this project a little better.
The conditional generates an ETag (usually based on the sha of the asset, or dynamically from the content on other views), and a Cache-Control header to specify how the objects should be cached.
The Cache-Control header value is configurable- and a default is specified.