Skip to content

Commit

Permalink
Improvements to favicons
Browse files Browse the repository at this point in the history
- Fix broken favicon file names and colors
- Add setting for custom favicon path
  • Loading branch information
hugopeek committed Jul 1, 2020
1 parent 1f5a532 commit 09144aa
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 8 deletions.
8 changes: 7 additions & 1 deletion _build/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"lowCaseName": "romanesco",
"description": "Romanesco is an engineering toolkit that combines the atomic design philosophy with MODX templating.",
"author": "Hugo Peek",
"version": "0.16.3",
"version": "0.16.4",
"package": {
"elements": {
"categories": [
Expand Down Expand Up @@ -5040,6 +5040,12 @@
"type": "textfield",
"area": "Pages"
},
{
"key": "favicon_path",
"type": "textfield",
"area": "Presentation",
"value": "assets/favicons"
},
{
"key": "favicon_version",
"type": "textfield",
Expand Down
5 changes: 5 additions & 0 deletions _build/src/00_electrons/presentation.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@

"systemSettings": [
{
"key": "favicon_path",
"type": "textfield",
"area": "Presentation",
"value": "assets/favicons"
},{
"key": "favicon_version",
"type": "textfield",
"area": "Presentation"
Expand Down
2 changes: 2 additions & 0 deletions core/components/romanesco/docs/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ Released on ...

Fixes and improvements:
- Refactor main accordion menu
- Fix broken favicon file names and colors
- Add setting for custom favicon path
- Add option to activate FormSource in FormBlocks reports
- Add ability to change custom CSS path (per context, if needed)
- Create absolute path for CSS backgrounds that won't be thumbnailed
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
<link rel="apple-touch-icon" sizes="180x180" href="assets/favicons/apple-touch-icon.png?v=[[++romanesco.favicon_version]]">
<link rel="icon" type="image/png" sizes="32x32" href="assets/favicons/favicon-32x32.png?v=[[++romanesco.favicon_version]]">
<link rel="icon" type="image/png" sizes="16x16" href="assets/favicons/favicon-16x16.png?v=[[++romanesco.favicon_version]]">
<link rel="manifest" href="assets/favicons/site.webmanifest?v=[[++romanesco.favicon_version]]">
<link rel="mask-icon" href="assets/favicons/safari-pinned-tab.svg?v=[[++romanesco.favicon_version]]" color="[[++favicon_theme_color:empty=`[[++theme_color_primary]]`]]">
<link rel="shortcut icon" href="assets/favicons/favicon.ico?v=[[++romanesco.favicon_version]]">
<meta name="theme-color" content="[[++favicon_theme_color:empty=`[[++theme_color_primary]]`]]">
<link rel="apple-touch-icon" sizes="180x180" href="[[++romanesco.favicon_path]]/apple-touch-icon.png?v=[[++romanesco.favicon_version]]">
<link rel="icon" type="image/png" sizes="32x32" href="[[++romanesco.favicon_path]]/favicon-32x32.png?v=[[++romanesco.favicon_version]]">
<link rel="icon" type="image/png" sizes="16x16" href="[[++romanesco.favicon_path]]/favicon-16x16.png?v=[[++romanesco.favicon_version]]">
<link rel="manifest" href="[[++romanesco.favicon_path]]/site.webmanifest?v=[[++romanesco.favicon_version]]">
<link rel="mask-icon" href="[[++romanesco.favicon_path]]/safari-pinned-tab.svg?v=[[++romanesco.favicon_version]]" color="#[[++favicon_theme_color:empty=`[[++theme_color_primary]]`]]">
<link rel="shortcut icon" href="[[++romanesco.favicon_path]]/favicon.ico?v=[[++romanesco.favicon_version]]">
<meta name="theme-color" content="#[[++favicon_theme_color:empty=`[[++theme_color_primary]]`]]">
<meta name="msapplication-TileColor" content="#[[++favicon_tile_color:empty=`[[++theme_color_primary]]`]]">
<meta name="apple-mobile-web-app-title" content="[[++favicon_app_title:empty=`[[++site_name]]`]]">
<meta name="application-name" content="[[++favicon_app_title:empty=`[[++site_name]]`]]">

0 comments on commit 09144aa

Please sign in to comment.