Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧲 Use our own require_bitsandbytes #2370

Merged
merged 2 commits into from
Nov 20, 2024
Merged

🧲 Use our own require_bitsandbytes #2370

merged 2 commits into from
Nov 20, 2024

Conversation

qgallouedec
Copy link
Member

What does this PR do?

To avoid this warning in our tests:

../transformers/src/transformers/testing_utils.py:1163
  /fsx/qgallouedec/transformers/src/transformers/testing_utils.py:1163: PytestUnknownMarkWarning: Unknown pytest.mark.bitsandbytes - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    return pytest.mark.bitsandbytes(test_case)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qgallouedec qgallouedec changed the title 🧲 Use our own `require_bitsandbytes 🧲 Use our own require_bitsandbytes Nov 19, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec
Copy link
Member Author

qgallouedec commented Nov 19, 2024

Failing test not related (fixed in #2373)

@qgallouedec qgallouedec merged commit 5626806 into main Nov 20, 2024
13 of 14 checks passed
@qgallouedec qgallouedec deleted the require_bitandbytes branch November 20, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants