-
Notifications
You must be signed in to change notification settings - Fork 27.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Byebye test_batching_equivalence
's flakiness
#35729
Draft
ydshieh
wants to merge
20
commits into
main
Choose a base branch
from
circleci_debug_base_MobileNetV1ModelTest_test_batching_equivalence
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Byebye test_batching_equivalence
's flakiness
#35729
ydshieh
wants to merge
20
commits into
main
from
circleci_debug_base_MobileNetV1ModelTest_test_batching_equivalence
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Au revoir flakyness 👋
The major ways of the fix
set_xxx_less_flaky
methods1e-20
or1e-39
) and theeps=-38
used, the cosine similarity is not in the range of[-1, 1]
and it's not stable.Still some flakyness
max()
ortopk
methods to compute some indices and use them in later computation, this is not stable (small difference even in the order of1e-9
could still get difference indices and cause later values to differ a bit larger)AutoformerAttention
: it usestopk
, but also the computation oftmp_delay
is wrong I believe (it won't keep the batch equivalence - I am sure about that, but not sure that is the original design)Esmfold
: unknown reason